HIVE-26332: Test surefire upgrade to 3.1.3-SNAPSHOT for SUREFIRE-1934 #5334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
zabetak
force-pushed
the
upgrade-surefire
branch
from
af6f1af
to
f0c2e2a
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests failed
tests pending
labels
1. Set `enableOutErrElements` to `false` to exclude system-out/system-err from XML report for succesful tests (retain current behavior). 2. Remove `failIfNoTests` since by default is false. 3. Set `failIfNoSpecifiedTests` to `false` since CI adds bogus `-Dtest` arguments for some stages.
There is STDOUT corruption due to the fact that tests write and use System.setOut. The problem only occurs when we are sending multiline commands (without semicolon) because org.apache.hive.beeline.Commands.handleMultiLineCmd (Line 1113). See also: https://maven.apache.org/surefire/maven-failsafe-plugin/faq.html#corruptedstream
zabetak
force-pushed
the
upgrade-surefire
branch
from
f0c2e2a
to
c06ca0c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Upgrade surefire plugin to 3.1.3-SNAPSHOT
Why are the changes needed?
Test if failures related to SUREFIRE-1934 are resolved and what else remains to be done for upgrading
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?